feat: update x-tailwindcss package to vue 3 #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianArenal
approved these changes
Nov 20, 2024
annacv
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Hi, if I am not wrong, there is no need to copy copyCssClassesToClipboard and removeClassPrefix as methods because we bind them when we use the XdsBaseShowcase component.
I tested removing those methods in xds-input.vue, xds-highlight.vue & xds-icon.vue and everything is working fine.
annacv
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refactoring Vue components in the
packages/x-tailwindcss/demodirectory to use the Composition API anddefineComponentfrom Vue 3. This allow us to remove the peer dependency to vue 2 for thex-tailwincdsspackage.BREAKING CHANGE: The showcase is no longer exported as Vue components but as web application.